Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33382 )
Change subject: [WIP] mb/google/{sarien, arcada} Fix for SSD can't be detected issue
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33382/2/src/mainboard/google/sarien/romstage...
File src/mainboard/google/sarien/romstage.c:
https://review.coreboot.org/#/c/33382/2/src/mainboard/google/sarien/romstage...
PS2, Line 74: }
What should we do if ps is NULL, set Power and Reset high?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03dabe1f75c761617c1129547342dff3047e101d
Gerrit-Change-Number: 33382
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 11 Jun 2019 00:01:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment