Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41638 )
Change subject: sb/intel/i82371eb: Add #defines for DEVRESx registers ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41638/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41638/1//COMMIT_MSG@9 PS1, Line 9: Change [41561] uses DEVRESB. : : [41561] https://review.coreboot.org/c/coreboot/+/41561 URLs in commit messages rot away. How about:
These registers will be put to use in a follow-up.
https://review.coreboot.org/c/coreboot/+/41638/1/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/i82371eb.h:
https://review.coreboot.org/c/coreboot/+/41638/1/src/southbridge/intel/i8237... PS1, Line 95: Why are there two extra spaces everywhere? I'd use a tab instead