Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34765 )
Change subject: kohaku: add TEMP_SENSOR_3 and TEMP_SENSOR_4 to DPTF ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 30: Thermal Sensor 3
Share info on what are these "Thermal Sensor 1/2/3/4" used for on this kohaku variant?
The Hatch reference design gave these generic names. I'll revise them for Kohaku.
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 31: #define DPTF_TSR2_PASSIVE 65 : #define DPTF_TSR2_CRITICAL 75
I think Paul referred to the new layout capture in b/138578073#comment5. […]
Yes, these values will be refined once we have hardware with the sensors.
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 53: /* CPU Throttle Effect on 5V (TSR1) */ : Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR1, 100, 94, 0, 0, 0, 0 }, : : /* Charger Throttle Effect on Charger (TSR0) */ : Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
Why did these change? Are the details captured somewhere?
On the Kohaku design, TSR1 is placed near the 5V supply, and TSR0 is placed near the charger, which is swapped compared to the hatch reference.
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/... PS1, Line 62: GT
Share more details on this GT throttling as per above comment.
The only information that I have is that the sensor is placed near GT. We should be able to adjust the values and provide better documentation once we have hardware.