[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/myst: Enable eSPI SCI events

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74101 )

Change subject: mb/google/myst: Enable eSPI SCI events
......................................................................

mb/google/myst: Enable eSPI SCI events

Enable EC SCI events for eSPI.

BUG=b:275894894
TEST=builds

Signed-off-by: Jon Murphy 
Change-Id: I8fd858c484f6fcf952bcb4f756ba2e4728091d8b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74101
Reviewed-by: Eric Lai 
Tested-by: build bot (Jenkins) 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/myst/ec.c
M src/mainboard/google/myst/mainboard.c
2 files changed, 39 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved
  Eric Lai: Looks good to me, approved

diff --git a/src/mainboard/google/myst/ec.c b/src/mainboard/google/myst/ec.c
index c369f14..060119d 100644
--- a/src/mainboard/google/myst/ec.c
+++ b/src/mainboard/google/myst/ec.c
@@ -1,9 +1,21 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

#include <acpi/acpi.h>
+#include <amdblocks/smi.h>
 #include <ec/google/chromeec/ec.h>
+#include <gpio.h>
+#include <soc/smi.h>
 #include <variant/ec.h>

+static const struct sci_source espi_sci_sources[] = {
+	{
+		.scimap = SMITYPE_ESPI_SCI_B,
+		.gpe = EC_SCI_GPI,
+		.direction = SMI_SCI_LVL_HIGH, /* enum smi_sci_lvl */
+		.level = SMI_SCI_EDG, /* enum smi_sci_dir */
+	}
+};
+
 void mainboard_ec_init(void)
 {
    const struct google_chromeec_event_info info = {
@@ -15,4 +27,7 @@
    };

google_chromeec_events_init(&info, acpi_is_wakeup_s3());
+
+	/* Configure eSPI SCI events */
+	gpe_configure_sci(espi_sci_sources, ARRAY_SIZE(espi_sci_sources));
 }
diff --git a/src/mainboard/google/myst/mainboard.c b/src/mainboard/google/myst/mainboard.c
index bdd4c76..e433c98 100644
--- a/src/mainboard/google/myst/mainboard.c
+++ b/src/mainboard/google/myst/mainboard.c
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

+#include <amdblocks/acpimmio.h>
 #include <amdblocks/amd_pci_util.h>
 #include <baseboard/variants.h>
 #include <console/console.h>
@@ -37,6 +38,10 @@
 static void mainboard_enable(struct device *dev)
 {
    printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+
+	/* TODO: b/184678786 - Move into espi_config */
+	/* Unmask eSPI IRQ 1 (Keyboard) */
+	pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1)));
 }

struct chip_operations mainboard_ops = {