build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41035 )
Change subject: soc/intel/common/gpio_defs: fix code style
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41035/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/41035/3/src/soc/intel/common/block/...
PS3, Line 202: #define PAD_CFG_NF_1V8(pad, pull, rst, func) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4b4c28153398b6275728b28bda90e527d97e823
Gerrit-Change-Number: 41035
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jun 2020 15:17:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment