Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Paul Menzel, Tim Van Patten.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76091/comment/c431e2b7_288e9acc : PS2, Line 12: Both SMU and FSP interpret configs > 3 as 3.
Why does this require an extra call to the SMU to be performed, since it sounds like something they' […]
There is a point early in the flow, where the FSP also does not know anything about the expected TDP and will use the default return of fused values from this call to make some decisions rather than the system configuration, if the system configuration does not fall within the values it has in the table.
https://review.coreboot.org/c/coreboot/+/76091/comment/9b13caec_51df11bf : PS2, Line 15: TEST=Confirm extra message is not sent in serial log.
Is there any validation of the DPTC settings themselves that can be done, to verify the new value do […]
In the source for pmfw, 3 was always used, the 4 was just replaced by 3 because it was >3.
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
PS2:
This change also needs to be made in `src/mainboard/google/skyrim/variants/winterhold/overridetree. […]
Acknowledged