Attention is currently required from: Arthur Heymans, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Raul Rangel.
Martin Roth has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/75441?usp=email )
Change subject: soc/amd/common/cpu: Don't assume endianness of host
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
Needs manual rebase.
File src/soc/amd/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75441/comment/713deb11_4e204f3a?usp... :
PS1, Line 24: hexdump
I used `od` in https://review.coreboot. […]
The issue is that hexdump isn't posix compliant. I guess the change is no worse than the already committed code though. I'd say let's just merge this and try to fix it later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75441?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16b0e6898ce808f12b8277d0fd6a09ff5c44ca15
Gerrit-Change-Number: 75441
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 15 Aug 2024 18:42:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com