Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75611?usp=email )
Change subject: soc/amd/*/root_complex: reserve IOMMU MMIO area
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS4:
btw, quick look read_resources could be common code.
ideally the common code for that should be split into the x86 architecture specific, silicon specific and fsp integration specific parts. still need to look into that, but it's not a too high priority for me at the moment
PS4:
I found the following in docs. I guess reserving the full 4G is a good idea. […]
yes, that's the part of the doc i looked at. the default address for the rom3 full spi flash mapping defaults to the same address; not sure why that is the case, but still seems to work.
instead of those 3 regions that cover most of the 4GB, i just reserved the full 4GB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75611?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a8150873cb019ca1d903ed269e18d6f9fabb871
Gerrit-Change-Number: 75611
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 15 Jun 2023 12:19:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment