[coreboot-gerrit] [S] Change in coreboot[master]: sb/intel/common: Drop duplicate smi_set_eos()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69668 )

Change subject: sb/intel/common: Drop duplicate smi_set_eos()
......................................................................

sb/intel/common: Drop duplicate smi_set_eos()

We have equivalent southbridge_smi_set_eos().

Change-Id: I03a48f0ec9efac2a220aa4ca502a5f504d78c585
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/x86/smm/smm_module_handler.c
M src/southbridge/intel/common/pmutil.c
M src/southbridge/intel/common/pmutil.h
3 files changed, 13 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/69668/1

diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c
index e813f78..32f66af 100644
--- a/src/cpu/x86/smm/smm_module_handler.c
+++ b/src/cpu/x86/smm/smm_module_handler.c
@@ -74,14 +74,6 @@
    printk(BIOS_DEBUG, "Unknown function\n");
 }

-/**
- * @brief Set the EOS bit
- */
-static void smi_set_eos(void)
-{
-	southbridge_smi_set_eos();
-}
-
 static u32 pci_orig;

/**
@@ -196,7 +188,7 @@
    smi_release_lock();

/* De-assert SMI# signal to allow another SMI */
-	smi_set_eos();
+	southbridge_smi_set_eos();
 }

RMODULE_ENTRY(smm_handler_start);
diff --git a/src/southbridge/intel/common/pmutil.c b/src/southbridge/intel/common/pmutil.c
index 02a8375..a43b95c 100644
--- a/src/southbridge/intel/common/pmutil.c
+++ b/src/southbridge/intel/common/pmutil.c
@@ -176,18 +176,6 @@
    printk(BIOS_DEBUG, "\n");
 }

-/**
- * @brief Set the EOS bit
- */
-void smi_set_eos(void)
-{
-	u8 reg8;
-
-	reg8 = read_pmbase8(SMI_EN);
-	reg8 |= EOS;
-	write_pmbase8(SMI_EN, reg8);
-}
-
 void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
 {
    int i;
diff --git a/src/southbridge/intel/common/pmutil.h b/src/southbridge/intel/common/pmutil.h
index c9cf544..ff7b5e8 100644
--- a/src/southbridge/intel/common/pmutil.h
+++ b/src/southbridge/intel/common/pmutil.h
@@ -120,7 +120,6 @@
 u32 reset_smi_status(void);
 void gpe0_mask(u32 clr, u32 set);
 void alt_gpi_mask(u16 clr, u16 set);
-void smi_set_eos(void);
 void dump_alt_gp_smi_status(u16 alt_gp_smi_sts);
 u16 reset_alt_gp_smi_status(void);
 void dump_all_status(void);