Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48694 )
Change subject: mb/prodrive/hermes: Update USB 2.0 settings ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48694/2/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48694/2/src/mainboard/prodrive/herm... PS2, Line 109: [10] = HERMES_USB2_CONFIG(OC_SKIP), /* BMC */ : [11] = USB2_PORT_EMPTY, : [12] = HERMES_USB2_CONFIG(OC_SKIP), /* piggy-back */ : [13] = HERMES_USB2_CONFIG(OC_SKIP), /* M.2 key E */ Q: Do these need to be changed as well? I feel `USB2_PORT_MID` makes more sense here