Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41760 )
Change subject: intel/fsp2_0: Add fsp_get_version() to copy FSP version to a char buffer
......................................................................
Patch Set 11:
It is generally easier to design such APIs from the callers
perspective. All the #if in the follow-up could be avoided
that way. For instance
size_t lb_get_chipset_blob_version(char *buf);
This could be paired with a Kconfig (also declared by the
caller) which would be selected by the blob driver and decide
if the API can be used. Alternatively, one could add a weak
implementation (but that would increase complexity for the
caller and I'm generally not fond of those).
The coreboot-tables code treats its table space as infinite
anyway, so this would also not need any constant for the
buffer size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I579fa87028b9ed0734b2fac206daf43ecae311be
Gerrit-Change-Number: 41760
Gerrit-PatchSet: 11
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jun 2020 10:57:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment