Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42439 )
Change subject: soc/intel/xeon_sp/cpx: rename xeon_sp_get_cpu_count()
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42439/4/src/soc/intel/xeon_sp/cpx/s...
File src/soc/intel/xeon_sp/cpx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42439/4/src/soc/intel/xeon_sp/cpx/s...
PS4, Line 118: num_cpus
This variable should be renamed as well, to `num_sockets`
Makes total sense. Thanks for pointing this out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic96bdf4ab042ac15d43f9b636185627c63fbf8a1
Gerrit-Change-Number: 42439
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 19:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment