Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )
Change subject: intelblocks/pep: Send All Monitor Off/On command only in FWCM case ......................................................................
intelblocks/pep: Send All Monitor Off/On command only in FWCM case
ALL_MONITOR_OFF command is sent using DPOF. TBT controller needs to be notified about ALL_MONITOR_OFF(TBT Displays OFF) only when Firmware Connection Manager(FWCM) is in use during S0ix Entry/Exit. When configured for SWCM this command should not be sent.
BUG=b:288536417 TEST= Build and boot Rex Proto-1. Verify S0ix working.
Signed-off-by: Usha P usha.p@intel.com Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75717 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Utkarsh H Patel utkarsh.h.patel@intel.corp-partner.google.com Reviewed-by: Jamie Ryu jamie.m.ryu@intel.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/common/block/acpi/pep.c 1 file changed, 10 insertions(+), 6 deletions(-)
Approvals: Utkarsh H Patel: Looks good to me, but someone else must approve Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Jamie Ryu: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/acpi/pep.c b/src/soc/intel/common/block/acpi/pep.c index b315019..5e03345 100644 --- a/src/soc/intel/common/block/acpi/pep.c +++ b/src/soc/intel/common/block/acpi/pep.c @@ -249,9 +249,11 @@ acpigen_write_if_end();
/* Handle Thunderbolt displays */ - acpigen_write_if_cond_ref_of(THUNDERBOLT_DEVICE); - acpigen_write_store_int_to_namestr(1, THUNDERBOLT_IOM_DPOF); - acpigen_write_if_end(); + if (CONFIG(FIRMWARE_CONNECTION_MANAGER)) { + acpigen_write_if_cond_ref_of(THUNDERBOLT_DEVICE); + acpigen_write_store_int_to_namestr(1, THUNDERBOLT_IOM_DPOF); + acpigen_write_if_end(); + } }
static void lpi_s0ix_exit(void *unused) @@ -274,9 +276,11 @@ acpigen_write_if_end();
/* Handle Thunderbolt displays */ - acpigen_write_if_cond_ref_of(THUNDERBOLT_DEVICE); - acpigen_write_store_int_to_namestr(0, THUNDERBOLT_IOM_DPOF); - acpigen_write_if_end(); + if (CONFIG(FIRMWARE_CONNECTION_MANAGER)) { + acpigen_write_if_cond_ref_of(THUNDERBOLT_DEVICE); + acpigen_write_store_int_to_namestr(0, THUNDERBOLT_IOM_DPOF); + acpigen_write_if_end(); + } }
static void lpi_display_on(void *unused)