Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik, Tarun.
Hello Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik, Tarun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84356?usp=email
to look at the new patch set (#2).
Change subject: drivers/intel/fsp2_0: Define 64-bit FSP_STATUS_GLOBAL_RESET ......................................................................
drivers/intel/fsp2_0: Define 64-bit FSP_STATUS_GLOBAL_RESET
FSP reset status type is efi_return_status_t (not uint32_t) which size varies with the FSP binary architecture (32-bit vs 64-bit).
This commit defines FSP_STATUS_GLOBAL_RESET accordingly to PLATFORM_USES_FSP2_X86_32 and take care of the side effect of such 64-bit value.
BUG=b:348678529 TEST=Verified with fatcat mainboard on pantherlake reference board
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/drivers/intel/fsp2_0/Kconfig M src/include/efi/efi_datatype.h M src/soc/intel/common/fsp_reset.c M src/soc/intel/common/reset.h M src/soc/intel/meteorlake/chip.c M src/soc/intel/pantherlake/chip.c 6 files changed, 24 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/84356/2