Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )
Change subject: vboot: create board-specific test-only GBB HWID if not set ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... File src/security/vboot/gen_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 1: #!/bin/sh
Shouldn't this go in $(top)/util/? I think host code (even scripts) is generally not allowed under $ […]
Done
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
Why don't we let futility calculate the checksum based on the input string? […]
Done