Attention is currently required from: Angel Pons, Varshit Pandya.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/dell/optiplex_9020/mainboard.c:
https://review.coreboot.org/c/coreboot/+/81529/comment/cfeeb8be_29bd981f : PS5, Line 290: die("Unknown GPIO chassis type\n");
I am fine with turning these into warning.
Turned this into a warning with fans at full speed
https://review.coreboot.org/c/coreboot/+/81529/comment/e39512cb_05694347 : PS5, Line 368: die("Unknown chassis type\n");
Can the fan still be set to run at full speed? Should work to prevent overheating.
See above.
https://review.coreboot.org/c/coreboot/+/81529/comment/1a908c0d_8605ce11 : PS5, Line 371: if (CONFIG_MAX_CPUS > 2) {
Mine is 4 core 4 thread, and that MSR returns 7 on mine, so I wonder what value would it be on the 2 […]
I am just going to make it always apply these values, I think that should match stock fw based on the MSR values I've read.
File src/mainboard/dell/optiplex_9020/sch5555_ec.h:
https://review.coreboot.org/c/coreboot/+/81529/comment/ec0bac30_9f7e9dc0 : PS5, Line 3: #pragma once
Indeed, I missed that as this file copy pasted from my user-space utility.
Fixed.