Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47381 )
Change subject: drivers/analogix: add MIPI rx flow ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@10 PS2, Line 10: enable enables
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@12 PS2, Line 12: delay delays
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@12 PS2, Line 12: release releasing
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 817: ***** I don't see similar patterns in this file. Would you mind removing it? Or even remove the entire message.
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 822: anx7625_reg_write Please handle the return value.
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 827: anx7625_reg_write Please handle the return value.
https://review.coreboot.org/c/coreboot/+/47381/2/src/drivers/analogix/anx762... PS2, Line 829: ANXINFO("***** mipi rx, dp tx initial finish.\n"); Same.