Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61368 )
Change subject: psp_verstage: add new svc for cezanne
......................................................................
Patch Set 1:
(2 comments)
File src/vendorcode/amd/fsp/cezanne/include/bl_uapp/bl_syscall_public.h:
https://review.coreboot.org/c/coreboot/+/61368/comment/dea37eee_a745315d
PS1, Line 53: #define SVC_SET_PLATFORM_BOOT_MODE 0x6C
nit: Why is 0x6B skipped?
0x6B was allocated for svc_set_fw_hash_table (CB:60289). It'll be dropped off cezanne but it'd be better to skip anyway.
https://review.coreboot.org/c/coreboot/+/61368/comment/c9909725_2bb12129
PS1, Line 144: CHROME_BOOK_BOOT_MODE_TYPE_MAX_LIMIT = 0x4, // used for boundary check
nit: I think CROS is more commonly used than CHROME_BOOK
These types and enums come from header file in the PSP release. I think we should minimize difference to avoid confusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bcc9e49a2b73d486cfecd7b240bf989cad94630
Gerrit-Change-Number: 61368
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 30 Jan 2022 22:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment