[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC mt6373 driver

[Jarried Lin (Code Review)]

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC mt6373 driver
......................................................................

Patch Set 25:

(5 comments)

File src/soc/mediatek/common/include/soc/mt6373.h:

https://review.coreboot.org/c/coreboot/+/85129/comment/5bc30bf2_d152a589?usp... :
PS19, Line 10: 					=
> fix the indent

Done

File src/soc/mediatek/common/mt6373.c:

https://review.coreboot.org/c/coreboot/+/85129/comment/098e85ed_7c131893?usp... :
PS19, Line 24: mt6373_write
> mt6373_write8

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/3353f950_6bf84efd?usp... :
PS19, Line 46: lock
> align with `key_project_setting`

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/3716043f_ff3abbe9?usp... :
PS19, Line 263: 	/* turn on vio28 for bringup*/
              : 	printk(BIOS_INFO, "[%s][MT6373]turn on vio28\n", __func__);
              : 	mt6373_write_field(0x1e2d, 0x9, 0xFFFF, 0);
              : 	mt6373_write_field(0x1d07, 0x1, 0xFFFF, 0);
> do we still need this ?

Done

https://review.coreboot.org/c/coreboot/+/85129/comment/d7ede3e1_22e73a79?usp... :
PS19, Line 270: 	mt6373_enable_vcn33_3(true);
              : 	mt6373_set_vcn33_3_voltage(3300000);
> what is this for ?

It is for display.