Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69612 )
Change subject: mb/google/rex: Add `disable_gpio_export_in_crs` for rex ......................................................................
mb/google/rex: Add `disable_gpio_export_in_crs` for rex
None of the touchscreens used in the rex program should require exporting of GPIOs in the ACPI _CRS method for any i2c device.
This can cause i2c devices to malfunction or cause timing sequence violations if ACPI exports a PowerResource for the device that uses GPIOs that are also exported in _CRS.
BUG=none TEST=Able to build and boot Google, Rex platform.
Without this patch:
[ERROR] I2C: 00:10: Exposing GPIOs in Power Resource and _CRS
With this patch:
None
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I578a60eff27f94d6dc94b900604bc7560337d60b --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/69612/1
diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index a7f5a95..f3b0fab 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -357,6 +357,7 @@ register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end