EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47639 )
Change subject: drivers/i2c/sx9310: Refactor register struct
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47639/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47639/4//COMMIT_MSG@9
PS4, Line 9: Kernel driver sx93xx is looking for reg_name and data. sx9310 and sx9324
: have very different register name. In order to support more sx93xx serials,
: refactor the register structure to be compatible for any register.
I think it would be better to add a separate driver for sx932x in coreboot. […]
okay, I can copy one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d10f747e617e69a7697882c373ffdea2b43b691
Gerrit-Change-Number: 47639
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Nov 2020 07:07:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment