Attention is currently required from: Robert Zieba. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 )
Change subject: util: Add amdfwread utility ......................................................................
Patch Set 3:
(9 comments)
File util/amdfwread/amdfwread.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/28adbf7d_da0249af PS3, Line 163: static uint64_t relative_offset(const psp_directory_header* header, uint32_t header_offset, "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/84e695e6_024d1ec0 PS3, Line 164: const psp_directory_entry* entry, size_t entry_index) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/972829ad_dae0526c PS3, Line 206: psp_directory_header *header, psp_directory_entry **entries, size_t *num_entries) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/16369895_fc91b7c0 PS3, Line 254: ¤t_entries,&num_current_entries) != 0) space required after that ',' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/1382b9e5_7a26376e PS3, Line 254: ¤t_entries,&num_current_entries) != 0) space required before that '&' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/2dab88db_ffbb5847 PS3, Line 257: while (1) { trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/66e2734e_658b3f76 PS3, Line 265: uint64_t fuse = mode << 62 | addr; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/2f6710a7_99edc9c0 PS3, Line 285: ¤t_entries,&num_current_entries) != 0) space required after that ',' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/1009e63d_9e369484 PS3, Line 285: ¤t_entries,&num_current_entries) != 0) space required before that '&' (ctx:OxV)