22 Apr
2023
22 Apr
'23
12:12 a.m.
Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74609 )
Change subject: mb/google/skyrim: Add mainboard chip.h ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174768): https://review.coreboot.org/c/coreboot/+/74609/comment/18c0395a_94b3786d PS2, Line 10: #endif adding a line without newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/74609
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f
Gerrit-Change-Number: 74609
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 22:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment