Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v...
PS2, Line 2: chip soc/amd/picasso
nit: new line after license
Done
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v...
PS2, Line 6: #define EC_PNP_ID 0x0c09
This too isn't used/needed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868
Gerrit-Change-Number: 41801
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 00:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment