Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44672 )
Change subject: vc/google/chromeos: load wifi_sar_defaults.hex as the main WiFi SAR CBFS source
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44672/2/src/vendorcode/google/chrom...
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/44672/2/src/vendorcode/google/chrom...
PS2, Line 17: if (filename == NULL)
: filename = WIFI_SAR_CBFS_FILENAME;
Ya. This code is weird. […]
I think it is probably to allow mainboards to also return NULL to use the default filename.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44672
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf859c7bdeb1f41b5144663ba1762e560dcfc789
Gerrit-Change-Number: 44672
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Aug 2020 19:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment