Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Angel Pons, Nick Vaccaro, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63471 )
Change subject: soc/intel/common: migrate GPMR driver
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/gpmr/gpmr.c:
https://review.coreboot.org/c/coreboot/+/63471/comment/97039f62_67f5b063
PS9, Line 20: void gpmr_or32(uint16_t offset, uint32_t ordata)
: {
: return pcr_or32(PID_DMI, offset, ordata);
: }
I would have harness GPMR driver with new APIs and marking APIs from static to non-static before start using this in SoC code.
May be you can inject a CL in between CB:63470 and CB:63471 to `enhanced GPMR driver` then this CL is to use the GPMR driver from SoC and rest of the common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00ac667e8d3f2ccefd8d51a8150a989fc8e5c7e2
Gerrit-Change-Number: 63471
Gerrit-PatchSet: 9
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 06:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment