[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8192: add spmfw loader

[Roger Lu (Code Review)]

Roger Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )

Change subject: mediatek/mt8192: add spmfw loader
......................................................................

Patch Set 29:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46389/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46389/4//COMMIT_MSG@12 
PS4, Line 12: SPM is able to turn off more power saving for
            : the SoC such as DRAM self-refresh
> “turn off more power saving” sounds strange.

Hi Paul, is this ok?

This patch helps load spmfw from cbfs to spm sram. Spm needs its own firmware to enable spm suspend/resume function which turns off several resources such as DRAM/mainpll/26M clk when linux system suspend.

https://review.coreboot.org/c/coreboot/+/46389/4//COMMIT_MSG@16 
PS4, Line 16: TEST=Asurada boots up to shell
> It didn’t before? I thought it’s about suspend and resume?

Hi Paul, Yes. It's about system suspend/resume and I will the change TEST comment as below.

TEST=Asurada system suspend/resume ok