Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42690 )
Change subject: soc/amd/common: Complete ACPIMMIO GPIO bank separation ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42690/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42690/4/src/soc/amd/common/block/gp... PS4, Line 83: return acpimmio_gpio0 + gpio_num * sizeof(uint32_t);
I skipped ahead a few patches to this one. […]
The inlined varinat moves away from <acpimmio.h> here. Intent is for this gpio.c to have full ownership of the GPIO bank. Sure, one could still dereference acpimmio_gpio0 elsewhere, but hopefully such attempt would get caught in the review and use of <gpio.h> APIs would be encorced instead.