Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nicholas Sudsgaard.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80695/comment/fa9ac821_d53f6e3e : PS3, Line 15: - All enum names now use the `AZALIA_` prefix.
I don't have a very strong opionion, let's see what others think
If I had a strong opinion, I'd have told you already :)
If in doubt, I always say it's up to the author. So IMO it's your call, Nicholas. Looking at the two boards, I'd say keep the prefix if you'd do one line per argument anyway. Or drop the prefix if you'd want to save lines then.
(also see other comment about scoping)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/acc96df5_bb1c6fa6 : PS4, Line 128: conn If I'm not mistaken, you could do `AZALIA_##conn` here. Then the macro user wouldn't have to provide the AZALIA_ prefix for every argument. But the enum values still would have the prefix to not pollute the global scope.