Attention is currently required from: Rory Liu, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism ......................................................................
Patch Set 3:
(3 comments)
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/7e38dde7_fc15bbee PS2, Line 252: struct drivers_net_config *config = dev->chip_info; : if (!config || !config->enable_aspm) : return;
Should we just change this to […]
Done
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/f05d925e_107b8341 PS3, Line 40: ASPM_L1_2 0xe059000f nit: ``` #define ASPM_L1_2_MASK 0xe059000f ``` so it is indented one space after CMD_REG_ASPM
https://review.coreboot.org/c/coreboot/+/61267/comment/f4ba8aeb_3502d42c PS3, Line 359: /* Enable ASPM_L1.2 */ : if (CONFIG(PCIEXP_ASPM)) : enable_aspm_l1_2(io_base); Is this applicable to both the 8168 and 8125 ?