Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email )
Change subject: mb/google/dedede: Add initial fw_config configuration setting
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/mainboard/google/dedede/variants/pirika/variant.c:
https://review.coreboot.org/c/coreboot/+/79930/comment/ba084ebf_13028c12 :
PS4, Line 14: 0x350000
I am not allowed to access this page, so it’d be great if the information could be added to the comm […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79930?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2
Gerrit-Change-Number: 79930
Gerrit-PatchSet: 7
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Anson Tseng
ansontseng@google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anson Tseng
ansontseng@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 11:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-MessageType: comment