Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74127 )
Change subject: amd/mendocino/root_complex: Restrict DPTC to 15W boards
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/mendocino/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172855):
https://review.coreboot.org/c/coreboot/+/74127/comment/a999ea56_e942d7be
PS1, Line 376: if(get_amd_smu_reported_tdp(&tdp) != CB_SUCCESS) {
space required before the open parenthesis '('
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94f3974fce6358e3cbb0c30c1af33eb7ecb29ad7
Gerrit-Change-Number: 74127
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 31 Mar 2023 23:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment