Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Pranava Y N, Subrata Banik, V Sowmya.
Poornima Tom has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83074?usp=email )
Change subject: mb/google/brya/var/nivviks: Add fw_config fields for wifi6 and wifi7
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/brya/variants/nivviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83074/comment/c237ba1e_01e1483e?usp... :
PS3, Line 296: end
Done […]
Done
File src/mainboard/google/brya/variants/nivviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83074/comment/02b7da36_4c0c5319?usp... :
PS4, Line 291: register "wake" = "GPE0_PME_B0"
: register "add_acpi_dma_property" = "true"
please move these changes into a separate CL
Acknowledged
Moved to new CL -> https://review.coreboot.org/c/coreboot/+/83138
https://review.coreboot.org/c/coreboot/+/83074/comment/71de60fc_25f3346a?usp... :
PS4, Line 294: device generic 0 on
: probe WIFI_CATEGORY WIFI_6
: end
: end
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83074?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4b218f772405bdb1b741b4d5e640d7b4f145cd76
Gerrit-Change-Number: 83074
Gerrit-PatchSet: 5
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 19 Jun 2024 20:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Poornima Tom
poornima.tom@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com