Attention is currently required from: Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61705 )
Change subject: mb/google/dedede/var/pirika: Add Wifi SAR for pasara
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/dedede/variants/pirika/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61705/comment/de59815c_6bc7ebd0
PS1, Line 3: $(CONFIG_FW_CONFIG)
ramstage-y since variant.c is not looking anything in FW_CONFIG.
Done
File src/mainboard/google/dedede/variants/pirika/variant.c:
https://review.coreboot.org/c/coreboot/+/61705/comment/ccf5adab_6fc455ce
PS1, Line 4: #include <fw_config.h>
Is it required?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida475307c8448c5c2758c289da7708484bcb89e3
Gerrit-Change-Number: 61705
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 03:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment