Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44566 )
Change subject: soc/mediatek/mt8192: Add dramc param struct
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44566/1/src/soc/mediatek/mt8192/inc...
File src/soc/mediatek/mt8192/include/soc/dramc_common_mt8192.h:
https://review.coreboot.org/c/coreboot/+/44566/1/src/soc/mediatek/mt8192/inc...
PS1, Line 13: RANK_0= 0,
spaces required around that '=' (ctx:VxW)
please fix this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bae57e6777ab6fc46c771a034f814dd1175be95
Gerrit-Change-Number: 44566
Gerrit-PatchSet: 1
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 19 Aug 2020 05:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment