Attention is currently required from: Elyes Haouas, Julius Werner, Martin L Roth.
Jakub Czapiga has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email )
Change subject: tree: Use pkgconf over pkg-config
......................................................................
Patch Set 4:
(1 comment)
File tests/data/lib/lzma-test/data.2.bin:
https://review.coreboot.org/c/coreboot/+/83157/comment/a704151a_d1ebc1c4?usp... :
PS1, Line 52: * pkgconf
Thx
You can probably drop `ibs=1`, but `skip=8` is mandatory to drop header from binary data. Also `data.{1,3,4}.lzma.bin` do not need to be regenerated as their uncompressed versions do not change. So commands below should solve the issue:
```
util/cbfs-compression-tool compress tests/data/lib/lzma-test/data.2.bin /tmp/file.lzma.bin lzma ;
dd if=/tmp/file.lzma.bin of=tests/data/lib/lzma-test/data.2.lzma.bin skip=8
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83157?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Gerrit-Change-Number: 83157
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 22 Jun 2024 13:48:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr