Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson, Zheng Bao.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58764 )
Change subject: amdfwtool: Pack out-of-bounds check into a function and move
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/58764/comment/542e2282_25b3faaf
PS3, Line 738: if (count > MAX_PSP_ENTRIES) {
count could increase by the number of valid items in fw_table + 1 (pspdir2 branch). […]
Ah, the other test is inside the loop. Yeah, just adding another test as suggested by Felix should resolve things.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71117d1c817c0b6ddaea4ea47aea91672cc6d55a
Gerrit-Change-Number: 58764
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 09 Nov 2021 16:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Gerrit-MessageType: comment