[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and t...

[Kyle Lin (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Yunlong Jia.

Kyle Lin has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email )

Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel
......................................................................

Patch Set 1:

(2 comments)

File src/mainboard/google/brya/variants/gothrax/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/85512/comment/3f7c3e2a_bacc7982?usp... :
PS1, Line 6: 		option DB_A		3
Please rename DB_A to something like DB_A_HDMI_LTE

https://review.coreboot.org/c/coreboot/+/85512/comment/300e0665_5cef5392?usp... :
PS1, Line 268: 					probe TOUCH_PANEL TOUCH_PANEL_DISABLE
Are there two elan touchpanels with the same address? Why using TOUCH_PANEL_DISABLE here?