Attention is currently required from: David Wu, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59087 )
Change subject: mb/google/brya/var/brask: Enable LAN driver to write MAC
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59087/comment/5eac8729_458a4958
PS3, Line 7: write
suggestion:
`program`
https://review.coreboot.org/c/coreboot/+/59087/comment/1b242038_c3c5f0ed
PS3, Line 10: writting
`programming`
?
Otherwise it kind of sounds like you mean writing the value to VPD, not programming the LAN with its MAC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb95b02fd6d61621ef46db4d63b48456a0a72732
Gerrit-Change-Number: 59087
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 19:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment