Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Add helper functions to CSE lib ......................................................................
Patch Set 14:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... PS14, Line 76: me_hfs which status register is this ? STS1 ? if yes then we already have the definitions in soc directory. shouldn't we remove those in this CL as well ?
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... PS14, Line 265: one line function description will help to understand
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... PS14, Line 282: csr |= CSR_READY; 281 and 282 can combine ?
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... PS14, Line 289: 15000 same here ?
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... PS14, Line 291: 100 can't use macro ?
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35226/14/src/soc/intel/common/block... PS14, Line 75: /* : * Clears the reset state in the Host CSR : */ doesn't req multi line comments