Attention is currently required from: Arthur Heymans, Martin Roth, Yu-Ping Wu.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56114 )
Change subject: Makefile.inc: Split of image generation in multiple targets
......................................................................
Patch Set 4:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56114/comment/b8ebf393_90ff47ec
PS4, Line 1129: mv $@.tmp $@
I think the point of this is to prevent corrupt or incomplete data written to $@, but you're chang […]
It works around race conditions: when building in parallel, some gnu make versions look for a file's existence to determine that steps waiting on that file are good to go.
Poses to be a problem if these files aren't complete yet (but the process writing them takes a while). The diversion via .tmp has nothing to do with debuggability.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353
Gerrit-Change-Number: 56114
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 08:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment