build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )
Change subject: WIP: A bunch of experiments for cr50 long pulses ......................................................................
Patch Set 3:
(11 comments)
https://review.coreboot.org/c/coreboot/+/43741/3/src/drivers/spi/tpm/tpm.c File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/43741/3/src/drivers/spi/tpm/tpm.c@5... PS3, Line 560: if (*p == *pp || *pp == '.') { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/43741/3/src/drivers/spi/tpm/tpm.c@5... PS3, Line 565: if (!*pp) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/43741/3/src/drivers/spi/tpm/tpm.c@5... PS3, Line 570: if (*p >= '0' && *p <= '9') { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/43741/3/src/drivers/spi/tpm/tpm.c@5... PS3, Line 571: cr50_firmware_version[state] = 10 * cr50_firmware_version[state] + (*p - '0'); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43741/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/chromeos.c:
https://review.coreboot.org/c/coreboot/+/43741/3/src/mainboard/google/voltee... PS3, Line 42: void mainboard_silicon_init_params(FSP_S_CONFIG *params) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43741/3/src/mainboard/google/voltee... PS3, Line 43: uint32_t *status = (uint32_t*)cbmem_find(CBMEM_ID_TPM_BOARD_CFG); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/43741/3/src/security/vboot/cr50.c File src/security/vboot/cr50.c:
https://review.coreboot.org/c/coreboot/+/43741/3/src/security/vboot/cr50.c@1... PS3, Line 17: void set_cr50_board_cfg(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43741/3/src/security/vboot/cr50.c@6... PS3, Line 60: /* Move state from CAR to CBMEM. */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43741/3/src/security/vboot/cr50.c@6... PS3, Line 60: /* Move state from CAR to CBMEM. */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/43741/3/src/security/vboot/cr50.c@6... PS3, Line 60: /* Move state from CAR to CBMEM. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43741/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43741/3/src/soc/intel/tigerlake/fsp... PS3, Line 210: /* S0iX: Selectively enable individual sub-states. code indent should use tabs where possible