Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43358 )
Change subject: cbgfx: Add blend functions to calculate transparency ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43358/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43358/3//COMMIT_MSG@10 PS3, Line 10: Adding
Add
Done
https://review.coreboot.org/c/coreboot/+/43358/3//COMMIT_MSG@11 PS3, Line 11: applying
apply
Done
https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers... PS3, Line 92: blend.alpha = 0;
Move this to the first line for consistency?
Done
https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers... PS3, Line 188: need_blend ? : apply_blend(rgb->red, blend.rgb.red) : rgb->red
Do we need to enclose this with parentheses?
Functionality, no. But if you think that it helps with readability, then let's put it in.