[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Add gpio-keys ACPI node for PENH

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )

Change subject: mb/google/volteer: Add gpio-keys ACPI node for PENH
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
PS5, Line 74: EDGE_BOTH
> Thanks for the pointer. […]

So many layers can't keep it all straight, I think I was mixing another platform (apollolake?) where we had to do some funky routing of GPIO interrupts through _GPE.

I forgot that since this change also configures the pad as GPIO not ACPI and routes with GpioInt it should end up going through the pinmux layer to configure the pad to interrupt the GPIO controller on both edges: (which we are already doing in coreboot anyway) 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/driv...