Jeff Chase has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41185 )
Change subject: mb/google/endeavour: chrontel: fix interrupt and compat string ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41185/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41185/1//COMMIT_MSG@8 PS1, Line 8:
Please summarize the problem, and explain the fix.
Done
https://review.coreboot.org/c/coreboot/+/41185/1//COMMIT_MSG@10 PS1, Line 10: TEST=cec-ctl with ch7322 driver
Please elaborate.
Done
https://review.coreboot.org/c/coreboot/+/41185/1/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/endeavour/gpio.c:
https://review.coreboot.org/c/coreboot/+/41185/1/src/mainboard/google/fizz/v... PS1, Line 31: PAD_CFG_GPI_APIC
What was the issue with this configuration?
The interrupt for this device was declared as GpioInt in the ACPI table but it was configured here to route to APIC directly instead of enabling the interrupt through the GPIO controller (as I understand it). The interrupt handler in the driver was not firing.
https://review.coreboot.org/c/coreboot/+/41185/1/src/mainboard/google/fizz/v... PS1, Line 31: EDGE
We typically apply LEVEL triggering at the pad to pass the input signal as is to the interrupt contr […]
Done