Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31608 )
Change subject: prog_loader: Associate TS_END_ROMSTAGE timestamp with postcar if exist ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31608/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31608/1//COMMIT_MSG@15 PS1, Line 15: Its
It’s
Done
https://review.coreboot.org/#/c/31608/1//COMMIT_MSG@17 PS1, Line 17: IA
What does this stand for?
Intel Architecture
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c@163 PS1, Line 163: its
it’s
Done
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c@164 PS1, Line 164: timestamp_add_now(TS_END_ROMSTAGE);
I might move this just before prog_run() line below. […]
If I move this just before prog_run() then I will be adding postcar stage loading and caching time as well for "end of romstage", isn't ? if you see in ramstage, there were another 2 timestamp to know ramstage loading and hashing time.
we can also something like that as postcar loading start and end
https://review.coreboot.org/#/c/31608/1/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/31608/1/src/lib/prog_loaders.c@132 PS1, Line 132: if (!IS_ENABLED(CONFIG_ARCH_POSTCAR_X86_32))
Maybe: […]
Done