John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41387 )
Change subject: mb/google/volteer: Enable TCSS DMA0 and DMA1 for Volteer
......................................................................
Patch Set 4:
(2 comments)
Patch Set 4:
(1 comment)
Will you create another patch for handle this with
yes
https://review.coreboot.org/c/coreboot/+/41387/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41387/4/src/mainboard/google/voltee...
PS4, Line 140: TcssDma0En
Can you let us know the plan for this? […]
I will drop the setting here. TcssDma0En will be based on 0d.2 on/off with another following patch.
https://review.coreboot.org/c/coreboot/+/41387/4/src/mainboard/google/voltee...
PS4, Line 243: on
Do we need this one enabled on volteer? Only TCP0/TCP1 are in use which should be the two ports on […]
There is implication for PM as TBT DMA1 is grouped together with TBT PCIe2 and PCIe3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05cc9e3964d8037d433fca443be6e8d5b444bbce
Gerrit-Change-Number: 41387
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 06:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment