Attention is currently required from: Eric Lai, Ivy Jian, Nick Vaccaro, Shelley Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80300?usp=email )
Change subject: mb/google/brox: Initialize TCHSCR_RST_L to 0
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80300/comment/c577a1fe_9486a3ca :
PS4, Line 10: was causing some leakage
Was it measured?
https://review.coreboot.org/c/coreboot/+/80300/comment/61e21fa5_3501d704 :
PS4, Line 10: Configuring it to 0 initially in
: romstage should fix this.
s/should fix/fixes/
?
https://review.coreboot.org/c/coreboot/+/80300/comment/b8e57473_370eeaa7 :
PS4, Line 11: Also, make sure that EN_PP3300_TCHSCR is
: initialized in romstage as well.
Why?
https://review.coreboot.org/c/coreboot/+/80300/comment/ad12b643_e924884a :
PS4, Line 13:
What does the schematic say?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80300?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5bf1901a3a40a38237b950abcb758f96aebcc1cf
Gerrit-Change-Number: 80300
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 08 Feb 2024 08:59:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment