Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42239 )
Change subject: vendorcode/intel: Add edk2-stable202005 support ......................................................................
Patch Set 4:
Patch Set 3: Code-Review+1 So we just had the leadership meeting and talked about this, and looks like having edk2 as a submodule is going to give quite a bit of trouble... Even taking an approach like we do for payloads would be troublesome for Jenkins builds, which run concurrently.
To recap:
With submodules we'd have to have a submodule per EDK version used, even if they point to the same repo, they'd point to different checkouts.
With dynamic download, as done with payloads right now, we have to adapt the build so we can download beforehand (Jenkins builds with networking disabled, and therefore doesn't build payloads as part of building coreboot) and we'd have to ensure that the tree can be used by multiple builds in parallel (that may require multiple EDK versions), so we're back to having all EDK versions checked out.
In short, even though I would like to use the edk2 repo directly, doing so would result in several technical problems. So, I believe it's just not worth the hassle.
We could use the full edk2 repo, but that would import _even more_ stuff we don't need for our build. Compared to that approach this commit is tiny.
So yeah, it sounds intriguing, but I'm not sure there's a benefit in keeping this separate.