Attention is currently required from: Jason Glenesk, Paul Menzel, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73971 )
Change subject: mb/amd/birman/ec.c: Update EC configuration
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73971/comment/13fadaf0_de3c3c9a
PS7, Line 7: Update EC configuration for birman
“for birman” is redundant. Maybe: […]
Good point! That flows better
File src/mainboard/amd/birman/ec.c:
https://review.coreboot.org/c/coreboot/+/73971/comment/78b4bf69_16bf5227
PS7, Line 219: for (i = 0; i < count; i++) {
Add a blank line above?
Done
https://review.coreboot.org/c/coreboot/+/73971/comment/cf29b61c_41e90720
PS7, Line 222: cfg[i].addr, tmp);
Fits on the previous line?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73971
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd9df120f555eb06f920f6263a8d2ab45c05baec
Gerrit-Change-Number: 73971
Gerrit-PatchSet: 8
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 10 Apr 2023 16:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment